Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

The original reason for the split was to make it possible for translators to focus on learner-facing text and de-prioritize educator-facing text. Do we no longer need that? The idea was that LMS would be translated into more languages than Studio would.

The decision doc doesn't make any reference to this original goal.

The original reason for the split was to make it possible for translators to focus on learner-facing text and de-prioritize educator-facing text. Do we no longer need that? The idea was that LMS would be translated into more languages than Studio would.

The decision doc doesn't make any reference to this original goal.

To be honest @nedbat most reviewers probably don't know that or don't know which files are for what purposes in Transifex. Could this be part of a future project to separate the LMS from the CMS (I read somewhere we should not refer to it as Studio anymore) ?

The original reason for the split was to make it possible for translators to focus on learner-facing text and de-prioritize educator-facing text. Do we no longer need that? The idea was that LMS would be translated into more languages than Studio would.

Thanks @nedbat for adding the specific reason, I tried to capture the context I know.

I'll update the decision with this context.

To be honest @nedbat most reviewers probably don't know that or don't know which files are for what purposes in Transifex. Could this be part of a future project to separate the LMS from the CMS?

I think so as well. Having worked on Open edX translations for a long time I also seem to forget this issue. The best shot for any language team is to translate 100% of the translations.

I'll wait for input from others after updating the context.

I agree with @sambapete that mostly translators/reviewers mightn't be aware of the difference of files/resources. I peronsally priori to a release would always foucs on learner facing UX, for example, (learning, account, profile, authn..etc MFEs).

Which bring us to the next point I want to mention, as the UX/UI platform is transforming into MFEs of which it's strings are stored in .json files rather than .po, so I would say whatever we end up choosen here, in long term it might not be that relevant.

Lastly, assuming we moved to a new simple process, would the translations/reviews from older resources be saved? This I bet the main thing reviewers/transltaors would be concerned about...

Thanks @ghassanmas for your input.

Lastly, assuming we moved to a new simple process, would the translations/reviews from older resources be saved? This I bet the main thing reviewers/transltaors would be concerned about...

I agree. In a best case scenario we'd copy the following:

• Translation for each entry in every language (easy effort)
• Reviewed/unreviewed status for every translation (requires more effort)

The same process would be followed regardless of whether we combine resources or not. I need to double check the Transifex API for controlling the Reviewed/Unreviewed status when moving entries between projects.

@nedbat I've updated this pull request to add another method of which preserves the Studio vs Platform separation but in 4 files instead of 11.

@nedbat Please let me know if this makes it a more acceptable decision.

@brian-smith-tcril Please let me know if this work should block the OEP-58 edx-platform atlas integration or not? I can move on and implement Option 1 by adding 11 .po files into the new openedx-translations project. While I don't prefer that, I could use your recommendation for timeline in terms of FC-0012 project.

@OmarIthawi I don't think it makes sense to move forward with openedx/openedx-translations#541 while there are still 11 resource files. I think we should decide if we want to go the "combine everything" or "combine everything, except for Studio" route first.

@nedbat Thanks for the feedback. Would you mind checking the new option which suggests splitting into edx-platform.po, edx-platform-js.po, cms.po and cms-js.po?

Has this been discussed in the translations working group? I generally lean towards less complex solutions (Option 1), so if that's OK with the people doing translation work in transifex I'd prefer we go that route.

Has this been discussed in the translations working group?

Not yet. The closest Transifex Working Group meeting will be held on Sept 20th, 2023. I think we should aim for async resolution of this decision.

I generally lean towards less complex solutions (Option 1), so if that's OK with the people doing translation work in transifex I'd prefer we go that route.

The 4-files certainly will require more effort to accomplish. So Option 1 is indeed easier to implement and manage.

I think we should aim for async resolution of this decision.

Works for me! Would you mind starting a thread in the #wg-translations channel?

Works for me! Would you mind starting a thread in the #wg-translations channel?

Done: https://openedx.slack.com/archives/C037XDB9KN1/p1692577800473309

I have a small concern as a reviewer in Transifex.

When you will be combining the files in a single django.po file and a single djangojs.po file, will we lose the strings review status and need to review them all over again?

This is what currently happens under the Open edX Releases project when the new releases are created (see release-palm and release-palm-js under fr_CA for example). As a result, I personally never review these files when a new release is created and only review the original po files under the edx-platform project.

I am concerned that the first time the files will be standardized we will have no choice but to review the strings again. Or is there somethings that will keep the review status in the new django.po and djangojs.po files?

I am concerned that the first time the files will be standardized we will have no choice but to review the strings again.

Thank you for raising that concern @sambapete! This shouldn't impact the decision about combining into 2 or 4 files though, as both scenarios involve combining the existing 11 files.

is there somethings that will keep the review status in the new django.po and djangojs.po files?

I believe so. The /resource_translations/{resource_translation_id} transifex API endpoint does allow us to get and set the reviewed status of any given resource translation. It may take a bit of effort to ensure we match up all the strings in the old files with the new files properly, but it is definitely something we should try to solve for.

I have a small concern as a reviewer in Transifex.

When you will be combining the files in a single django.po file and a single djangojs.po file, will we lose the strings review status and need to review them all over again?

This is what currently happens under the Open edX Releases project when the new releases are created (see release-palm and release-palm-js under fr_CA for example). As a result, I personally never review these files when a new release is created and only review the original po files under the edx-platform project.

I am concerned that the first time the files will be standardized we will have no choice but to review the strings again. Or is there somethings that will keep the review status in the new django.po and djangojs.po files?

I'm working on a solution for that. It's yet to be done but so far I was able to copy review status:

• feat: sync from old transifex project openedx-translations#569

It's promising so far and thanks for your input @sambapete :)

Hi @OmarIthawi! Just flagging the new tests that have popped up, per the recent update: https://discuss.openedx.org/t/minor-change-to-edx-platform-check-statuses/11131

@brian-smith-tcril I think it's now ready for merge. I hope we've left a very good trail for future maintainers of edx-platform to understand the decision and its consequences.

@jristau1984 you're listed as "Review required from" for this repo on the spreadsheet, would you mind taking a look at this one?

@jristau1984 you're listed as "Review required from" for this repo on the spreadsheet, would you mind taking a look at this one?

I am listed as a reviewer for edx-platform? Can you please point me to where that is logged, I should update it. I have no more context here than anyone who is involved, my review should not be required.

@jristau1984 you're listed as "Review required from" for this repo on the spreadsheet, would you mind taking a look at this one?

I am listed as a reviewer for edx-platform? Can you please point me to where that is logged, I should update it. I have no more context here than anyone who is involved, my review should not be required.

I believe that would be @jmbowman. So I'm guessing it's a typo. Sorry @jristau1984!!

So I'm guessing it's a typo

That cell was updated in the most recent edit to the spreadsheet (about 20 minutes after my ping). Glad that spreadsheet is in order now.

do you need someone from our team to merge this?

@rgraber I can merge it. Thanks for asking!

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

2U Release Notice: This PR has been deployed to the edX production environment.

Great news!! This is now merged :)

Thanks everyone!